Brussels | ITP-2025-1 | Preeti Tyagi | Week 6 | Sprint 3 Coursework/sprint 3 implement and rewrite#35
Closed
preeti-t wants to merge 6 commits intoHackYourFutureBelgium:mainfrom
Conversation
Added all the cases required.
checked all the cases
updated according to the requirements.
added return function for different cases
added return function to cases
updated return values for different cases
MustafaBora
reviewed
Jan 7, 2026
| // Input: numerator = 3, denominator = -8 | ||
| // target output: true | ||
| // Explanation: The fraction 3/-8 is not a proper fraction because the numerator is equal to the denominator. The function should return true. | ||
| const negativeDenominator = isProperFraction(3, -8); |
There was a problem hiding this comment.
Good example, most doesn't look for absolute values. You also cover edge cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.